Skip to content

wp_dashboard_recent_comments function: avoid unnecessary SQL query#10736

Open
kalessil wants to merge 2 commits intoWordPress:trunkfrom
kalessil:perfromance/64506-unnecessary-sql-in-recent-comments-widget
Open

wp_dashboard_recent_comments function: avoid unnecessary SQL query#10736
kalessil wants to merge 2 commits intoWordPress:trunkfrom
kalessil:perfromance/64506-unnecessary-sql-in-recent-comments-widget

Conversation

@kalessil
Copy link

@kalessil kalessil commented Jan 15, 2026 •
edited
Loading

Tune wp_dashboard_recent_comments performance:

  • further reduce the number of count calls (related to the history of changes in this function)
  • harden while-loop condition to avoid SQLs when the last query fetched less than what was aimed (next query fetches nothing)

Trac ticket: https://core.trac.wordpress.org/ticket/64506

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @kalessil.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@kalessil kalessil mentioned this pull request Jan 15, 2026
Merged
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter westonruter requested a review from Copilot January 21, 2026 00:35
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the performance of the wp_dashboard_recent_comments function by reducing unnecessary function calls and avoiding SQL queries when no more results are available.

Changes:

  • Replace repeated count($comments) calls with an incremented counter variable
  • Add a condition to the while-loop to exit early when the last query returned fewer results than requested

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalessil